[TASK] Move ParserTest to Unit namespace#1592
Closed
JakeQZ wants to merge 1 commit into
Closed
Conversation
The test methods in this class are unit tests, testing only the `Parser` class.
JakeQZ
added
cleanup
testing
|
coverage: 73.3%. remained the same — test/unit-parser into main |
Collaborator
Author
|
Actually, |
Collaborator
|
Yeah, I vaguely remember discussing this a long time ago and then concluding that the parser tests need to be functional or integration as the parser class makes heavy use of almost all other classes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test methods in this class are unit tests, testing only the
Parserclass.